DOC: Clarify rolling min_periods default value GH21489 #23021
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @mattboggess! Thanks for submitting the PR.
|
Codecov Report
@@ Coverage Diff @@
## master #23021 +/- ##
=======================================
Coverage 92.19% 92.19%
=======================================
Files 169 169
Lines 50835 50835
=======================================
Hits 46868 46868
Misses 3967 3967
Continue to review full report at Codecov.
|
gfyoung
reviewed
Oct 7, 2018
pandas/core/window.py
Outdated
| @@ -462,7 +462,8 @@ class Window(_Window): | |||
| min_periods : int, default None | |||
| Minimum number of observations in window required to have a value | |||
| (otherwise result is NA). For a window that is specified by an offset, | |||
| this will default to 1. | |||
| this will default to 1. Otherwise, this will default to the size of the | |||
| window. | |||
There was a problem hiding this comment.
Nit: the pronoun "this" is grammatically vague here. Can we replace "this" with "min_periods" (surrounded with backticks)?
There was a problem hiding this comment.
Yeah that's better. This has been replaced.
|
this is fine. thank you. |
tm9k1
pushed a commit
to tm9k1/pandas
that referenced
this pull request
Nov 19, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
git diff upstream/master -u -- "*.py" | flake8 --diff